-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[common] Introduce BitmapFileIndexMetaV2. #5028
base: master
Are you sure you want to change the base?
Conversation
paimon-common/src/main/java/org/apache/paimon/fileindex/bitmap/BitmapFileIndexMetaV2.java
Show resolved
Hide resolved
paimon-common/src/main/java/org/apache/paimon/fileindex/bitmap/BitmapFileIndex.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hang8929201 Thanks for your patience!
+1 cc @JingsongLi
+1 |
I found another question that needs to be discussed. Should the index version default to v1 or v2? @Tan-JiaLiang @JingsongLi |
I don't have a clear idea, although it may cause compatibility issues, bitmap should not be used too much. Maintaining the default version to 1 is a relatively conservative choice. |
paimon-common/src/main/java/org/apache/paimon/fileindex/bitmap/BitmapFileIndex.java
Show resolved
Hide resolved
* | ... | | ||
* +-------------------------------------------------+----------------- | ||
* | ||
* index block format: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should have ability to compress index block?
Options options; | ||
|
||
void tryDeserialize() { | ||
if (entryList == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can take a look to https://cwiki.apache.org/confluence/display/PAIMON/PIP-25%3A+Introduce+a+key-value+file+format+for+paimon+primary+key+table
Here just something like LevelDB sst block, we can store length to avoid deserialize all entries.
Purpose
When the bitmap-indexed column cardinality is high, using the first version of the bitmap index format will take a lot of time to read the entire dictionary. But in fact we don't need a full dictionary when dealing with a small number of predicates, the performance of predicate hits on the bitmap can be improved by creating a secondary index on the dictionary.
https://docs.google.com/document/d/11dJlGlSX3dwYKKrPN0DQ2XQTsx6d9wI6DTBIiiBwomM/edit?tab=t.0
performance
cardinality 1000:
![image](https://private-user-images.githubusercontent.com/43694260/406287342-13f37f74-0554-4ed3-a636-1ff4bd2f74e7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNTMxMzksIm5iZiI6MTczOTM1MjgzOSwicGF0aCI6Ii80MzY5NDI2MC80MDYyODczNDItMTNmMzdmNzQtMDU1NC00ZWQzLWE2MzYtMWZmNGJkMmY3NGU3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDA5MzM1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRmNWQ3YzYzYmIxMWNmN2YyMDBjZmE1NTcyM2VmYjdmNjY5NTMxNjA5MjM1NDJjZGY1NjBhMGE0YWMyNzBkZDgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ZRUdoJSyuf9VSd-wVMFXh3L918ZcdatIpaM7J4Wc3XM)
cardinality 10000:
![image](https://private-user-images.githubusercontent.com/43694260/406287546-67190753-08df-4cae-93e6-c082f7e82199.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNTMxMzksIm5iZiI6MTczOTM1MjgzOSwicGF0aCI6Ii80MzY5NDI2MC80MDYyODc1NDYtNjcxOTA3NTMtMDhkZi00Y2FlLTkzZTYtYzA4MmY3ZTgyMTk5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDA5MzM1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWMwNDRjOTE2OWIxNTM4NmYyYWU5YWE2M2QzN2I1OTQxYmQwNzE0MTgxZTBmNjY4MTYwY2Y2YjRiMTY2OTA2MDAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.cQRz1N-Ms_2Fdr0D8I-gbZsWC_PYMjwbN_FFQLixlUE)
cardinality 30000:
![image](https://private-user-images.githubusercontent.com/43694260/406287663-622071c5-3622-45ce-b468-cc164a1a7b3f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNTMxMzksIm5iZiI6MTczOTM1MjgzOSwicGF0aCI6Ii80MzY5NDI2MC80MDYyODc2NjMtNjIyMDcxYzUtMzYyMi00NWNlLWI0NjgtY2MxNjRhMWE3YjNmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDA5MzM1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIyZmRiYWM3ODJhNjY0YjJkNWNhM2JkMzZjZGIxZDk5OWVlYmRjNWYwMzE4NDgxNTI4ODQxMjI1MWQxNTNmNjkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.lbc21oOnPk9_tCGKQqdXu0p5MAYHAHNRGGHoIm5kYUs)
cardinality 50000:
![image](https://private-user-images.githubusercontent.com/43694260/406287913-0c5ad1e9-9a82-4f72-804d-8231d70911b0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNTMxMzksIm5iZiI6MTczOTM1MjgzOSwicGF0aCI6Ii80MzY5NDI2MC80MDYyODc5MTMtMGM1YWQxZTktOWE4Mi00ZjcyLTgwNGQtODIzMWQ3MDkxMWIwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDA5MzM1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUwM2I0OGYwN2E5NjRhYTFkMzZhZDM4NjgyNDlmYTM0OTMxOGZiNzcwMmRiMzM4ZjI5OTk4OGQ2NmZjMjkyZWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.7K6HhILxqn2aZUvuyHixYMG2AHeceacNVGl-btOzECk)
cardinality 80000:
![image](https://private-user-images.githubusercontent.com/43694260/406288045-c823a006-6c23-44e9-9429-3492cf36d058.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNTMxMzksIm5iZiI6MTczOTM1MjgzOSwicGF0aCI6Ii80MzY5NDI2MC80MDYyODgwNDUtYzgyM2EwMDYtNmMyMy00NGU5LTk0MjktMzQ5MmNmMzZkMDU4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDA5MzM1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMyNzkyNjU2ZmM3MThiNjI1MjA4YTEzODcwYjkyOTliODVhODBmYjk4NzBjMzFiZjI4YWM5ZDdhMzg0ZDg2Y2UmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Py-njM5VmwfioE6811LNuZwqhcGB9B1G1e70TVnkGMo)
cardinality 100000:
![image](https://private-user-images.githubusercontent.com/43694260/406288167-af9d081e-0a62-42e1-b5ac-550d76f4b5fd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNTMxMzksIm5iZiI6MTczOTM1MjgzOSwicGF0aCI6Ii80MzY5NDI2MC80MDYyODgxNjctYWY5ZDA4MWUtMGE2Mi00MmUxLWI1YWMtNTUwZDc2ZjRiNWZkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDA5MzM1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEyNDY3YjgyOTM5ZWIxYzZkMjVjOGU1YWI1ZTJjMWZiZDU1NmYyY2YwNTk0NzhlZmY1MTNkYTNlZDllM2MxYWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.c_UebDqHdO1hkIr2Z8EglwFG26H0l4w2e0BQTdGcOSk)
Tests
org.apache.paimon.fileindex.bitmapindex.TestBitmapFileIndex
org.apache.paimon.spark.SparkFileIndexITCase
org.apache.paimon.benchmark.bitmap.BitmapIndexBenchmark
API and Format
Documentation
docs/content/concepts/spec/fileindex.md